For this week, I did actual coding on the same project on my first pull request a SimonSaysGame. The code was much more easier to read after I read through everything and added comments to it. Everything started to make sense and clicked to me. I figure out the general architecture of the source code and code scheming.
For this pull request, I found a bug where a game over can happen before the game even start or revealing what's the first color. So I created an issue and ask to get assigned to it, then I started working on it #60. The issue was relatively easy to fix. All I had to do was disable the buttons before the game start and desaturate the buttons, then enable the buttons after the game starts and re-saturate them. So I added a new css class to disable the hover over effects and desaturate them then add them to the buttons. Then remove the class on the buttons after the game starts the return them to normal. This took a few instances of research. Its just a new function to fix the issue.
As for the pull request, their wasn't any issue. No conflicts came up because the main wasn't updated since when I forked the project. So that part was nice.
From this I learned that with documentation, the source code is much more easier to read. Though for the most part it is easier since i read through the entire code first. Also it was a bit daunting to me at first for trying to actually code this time, but it turns out it wasn't that bad. So I can maybe more confident on my 3rd pull request on another project.
Issue: Disable the color buttons before the game start. #60
Pull request: Disable btns before start
Top comments (0)