DEV Community

And then the interviewer asks, "Can you do this with less code?"

Michael Solati on May 08, 2020

I LOVE fun solutions to interview problems. When prepping for interviews, I believe it's important to understand the capabilities and data structur...

Read full post

Donald Feury • May 9 '20

My answer to "Can you make it faster" is:

Do we need to? Has this become a bottle neck performance wise?

If not, don't care, lets spend time building a better product where it actually matters.

Michal Haták • May 9 '20

While I completely agree with that, I think main purpose of that excercise is to identify that developer know what performance limits of that code are.

I mean, You don't have to worry about performance issues when your devs are delivering optimized code by default, while avoiding premature optimizations :)

Donald Feury • May 9 '20

Of course, if they answer with "Lets assume that yes it has become/will become a bottle neck", then I would do my best to optimize.

Kyle Stephens • May 9 '20

^^^^ This ^^^^

Users don't care how a product is built. They care what the product is and that it solves their problems.

Donald Feury • May 9 '20

And this extends beyond programming

Hows the marketing?
Hows user retention?
Is it actually solving the target group's problem?

You can have the most efficient and well engineered product but if no one knows about it or it isn't solving their problem, none of that matters

Austin S. Hemmelgarn • May 9 '20

OK, now I'm curious: Does the ECMA standard actually guarantee Θ(n) time complexity for instantiation of a Set from an arbitrary Array?

I could easily see all the implementations happening to have Θ(n) time complexity for it, but unless the standard says that it always will be, you can't really say it's Θ(n) without specifying an implementation.

Michael Solati • May 9 '20 • Edited

So the first method is Θ(n log(n)), Mozilla and Google's implementations are a Merge Sort and Timsort respectively.

As for the the ECMA standard for a Set, internally they're recommended to use hash tables (or something similar). Insertion in hash tables run at Θ(1), so an array of n elements would reasonably be Θ(n).

Pol Monroig Company • May 9 '20

Well yes, but worst case of hash tables is linear. If you don't mind the space you can create an auxiliar array and mark the positions. This is the "same" idea used in the hash table but it guarantees a O(n) solution. This solution requires O(n) extra space complexity, but hash table in worst case is also O(n) ( when all numbers are different)

leob • May 9 '20

Good point, the fact that it's built-in doesn't necessarily mean faster.

Cully Larson • May 9 '20 • Edited

Great idea for an article. It's a good reminder that interviewers may want to drill down into a question. Just FYI, the original function is O(n log(n) + n) which is O(n log(n)). It isn't O(n). So your second version is actually quite a bit faster. Also, big-theta (Θ) is different from big-oh.

Michael Solati • May 9 '20

You're right, it's been a while since I've had to do time complexity, I'll update it.

Cully Larson • May 9 '20 • Edited

I had to double-check myself that n log(n) is higher order than n :)

Jochem Stoel • May 9 '20

You can do it with less code, the parenthesis can be omitted here. :P

const duplicateCheck = a => new Set(a).size !== a.length;

Michiel Hendriks • May 9 '20

If you are going to assume a is an array, then you could even use !=.

Michael Solati • May 9 '20

Haha, I thought so too. And I guess we could use let instead of const since it's one letter less.

Jon Randy 🎖️ • May 10 '20

const duplicateCheck = a => a.length - new Set(a).size;

Shorter and more useful since it returns the number of duplicates

Michiel Hendriks • May 10 '20 • Edited

const duplicateCount = a => a.length - new Set(a).size;

And now with a meaningful name. Because, what does duplicateCheck mean, that is has, or does not have duplicates. For the boolean version hasDuplicates would be the better name.

JP Antunes • May 9 '20

I really like one-liners, reminds me of how fun it was working with Perl way back when :-)

Here's one that I came up with a couple of days ago:
How to convert RGB values to a capitalised hex string? Mind you that valid decimal values for RGB are 0 - 255. Any values that fall out of that range must be rounded to the closest valid value.

const rgb = (r, g, b) => Buffer.from(new Uint8ClampedArray([r, g, b])).toString('hex').toUpperCase()

easrng • May 9 '20

Golfed, but less checking:

const rgb = (...a) => Buffer.from(new Uint8ClampedArray(a)).toString('hex').toUpperCase()

JP Antunes • May 9 '20 • Edited

Nice one! Here's a list I made a few months back: dev.to/jpantunes/js-warmup-exercis...

On a second look, your version only shaves off 2 characters and introduces a possible bug imho because you don't control how many parameters are passed to the function, so calling it either less or more than 3 values it will output a wrong value, right?

leob • May 9 '20

I love the "FP" (Functional Programming) style enhancements that have been added to Javascript and various other programming languages ... whenever I see a chance to replace an old-fashioned loop with a more concise map-filter-reduce construct I'm not hesitating to do so.

Max Ong Zong Bao • May 9 '20 • Edited

Great stuff, I might ask the interviewer "what is the reason for it?", "May i know In what area for this piece of code will be used?" to buy yourself time to think and help to understand the question better instead of just doing what you are told?

Michael Solati • May 9 '20

It's always important to try to extract as much info about the problem you're solving for. I agree with that.

Michael Solati • May 9 '20

Haha, true. Honestly coming up with titles is hard 😅. Buuut that's the solution to the question, which I guess requires you to click and read the article to see...