DEV Community

Yonatan Karp-Rudin
Yonatan Karp-Rudin

Posted on • Originally published at yonatankarp.com on

Kotlin Code Smell 11 - God Objects

TL;DR: Avoid taking on excessive responsibilities. Use the single responsibility principle.

Problems

  • Lack of cohesion

  • Tight coupling

Solutions

Examples

  • Libraries

Exceptions

Sample Code

Wrong

class Soldier {
    fun run() {}
    fun fight() {}
    fun driveGeneral() {}
    fun clean() {}
    fun fire() {}
    fun bePromoted() {}
    fun serialize() {}
    fun display() {}
    fun persistOnDatabase() {}
    fun toXML() {}
    fun jsonDecode() {}
    //...     
}
Enter fullscreen mode Exit fullscreen mode

Right

class Soldier {
    fun run() {}
    fun fight() {}
    fun clean() {}
}
Enter fullscreen mode Exit fullscreen mode

Conclusion

In Object-Oriented Programming, we distribute responsibilities among multiple objects.


Stay updated with my latest thoughts and ideas by registering for my newsletter. Connect with me on LinkedIn or Twitter. Let's stay connected and keep the conversation going!


More info

Credits

Top comments (0)