Transform your rigid inheritance into flexible delegations
TL;DR: Replace restrictive inheritance hierarchies with flexible object delegation
Problems Addressed π€―
- Liskov substitution violation
- Rigid class hierarchy
- Hidden dependencies
- Tight Coupling
- Limited Reusability
- Single Responsibility principle violation
Related Code Smells π§βπ»

Code Smell 290 - Refused Bequest
Maxi Contieri γ» Feb 12

Code Smell 11 - Subclassification for Code Reuse
Maxi Contieri γ» Oct 30 '20
Steps π
- Create a temporary field in the subclass for the superclass.
- Update subclass methods to delegate calls.
- Add delegation methods for inherited behavior.
- Remove inheritance and update object creation.
Sample Code π»
Before π¨
class Chatbot {
public void respond(String question) {
// Here is the logic to answer a question
}
}
class Robot extends Chatbot {
// The Physical Robot inherits the logic
// to answer questions
// and adds physical behavior
public void move() {
System.out.println("Moving...");
}
public void grab() {
System.out.println("Grabbing object...");
}
}
After
class Brain {
public String answer(String question) {
// The common logic to answer questions
// is extracted into a different object
return "Thinking... Answering: " + question;
}
}
final class Chatbot {
private final Brain brain;
Chatbot(Brain brain) {
this.brain = brain;
}
public void respond(String question) {
System.out.println(this.brain.answer(question));
}
}
final class Robot {
// 4. Remove inheritance and update object creation.
private final Brain brain;
// 1. Create a temporary field in the subclass for the superclass.
// private final Chatbot chatbot;
Robot(Brain brain) {
this.brain = brain;
// 2. Update subclass methods to delegate calls.
// this.chatbot = new Chatbot(brain);
// This code is removed after step 4
}
public void move() {
System.out.println("Moving...");
}
public void grab() {
System.out.println("Grabbing object...");
}
public void respond(String question) {
// 3. Add delegation methods for inherited behavior.
// chatbot.respond(question);
// This code is also removed after step 4
System.out.println(this.brain.answer(question));
// The physical robot can also use it as text-to-speech
}
}
Type π οΈ
[X] Semi-Automatic
Safety π‘οΈ
This refactoring is safe when done carefully and with proper testing.
You should ensure all delegated method signatures match exactly and maintain existing behavior.
The main risk comes from missing methods that need delegation or incorrectly implementing the delegation methods.
Why is the Code Better? β¨
You gain the flexibility to change implementations at runtime and avoid the pitfalls of inheritance like tight coupling.
How Does it Improve the Bijection?
This refactoring improves the Bijection between code and reality by better modeling real-world relationships.
A robot doesn't inherit from a brain in the real world - it has a brain.
By replacing inheritance with delegation, you create a more accurate representation of the actual relationship between objects using the MAPPER.
Limitations β οΈ
The rewriting requires writing additional delegation methods.
If subclass logic relies too much on the superclass, delegation might increase boilerplate.
Refactor with AI
Without Proper Instructions | With Specific Instructions |
---|---|
ChatGPT | ChatGPT |
Claude | Claude |
Perplexity | Perplexity |
Copilot | Copilot |
Gemini | Gemini |
DeepSeek | DeepSeek |
Meta AI | Meta AI |
Tags π·οΈ
- Inheritance
Related Refactorings π

Refactoring 007 - Extract Class
Maxi Contieri γ» Jul 4 '22
See also π
Credits
Image by Gerd Altmann on Pixabay
This article is part of the Refactoring Series.
Top comments (0)